Merge pull request #1008 from googlefonts/traffic-sub

PushItem improve __eq__
googlefonts · Jul 22, 2024 · cba6fd5 · cba6fd5
2 parents 890d7af + 5c998c8
commit cba6fd5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Lib/gftools/push/trafficjam.py b/Lib/gftools/push/trafficjam.py
@@ -218,7 +218,7 @@ def __hash__(self) -> int:
         return hash(self.path)
 
     def __eq__(self, other):
-        return self.path == other.path
+        return (self.path, self.url) == (other.path, other.url)
 
     def exists(self) -> bool:
         from gftools.push.utils import google_path_to_repo_path

diff --git a/tests/push/test_trafficjam.py b/tests/push/test_trafficjam.py
@@ -35,7 +35,7 @@
             PushItem(
                 Path("ofl/mavenpro"), PushCategory.UPGRADE, PushStatus.IN_DEV, "46"
             ),
-            True,
+            False,
         ),
         (
             PushItem(
-Original file line number
+Diff line change
@@ Expand Up / @@ -35,7 +35,7 @@ @@
                 PushItem(
                     Path("ofl/mavenpro"), PushCategory.UPGRADE, PushStatus.IN_DEV, "46"
                 ),
-                True,
+                False,
             ),
             (
                 PushItem(
@@ Expand Down @@