Disable JSON structure when using fontc #1067
Conversation
|
@cmyr With this I can build Noto fonts using fontc, except of course all the static generation is gone. |
simoncozens
force-pushed
the
fontc-builder-no-json
branch
from
8f99e62 to
9429896
Compare
|
With --experimental-fontc, building Noto Sans Arabic now takes 1m 52s on my machine, compared to 1m 24 without, presumably because of the slower UFO marshalling. I would be very interested in changing the |
There was a problem hiding this comment.
I'm glad you're finding this helpful! My only real desire with the fontc-supporting code is that it continues to support the needs of crater as well as it does now, which means really doing the minimal amount of work possible to get us the artifacts we're comparing, which are one generated binary per run. So long as we can continue doing that as needed, then this looks good.
Do ping me before publishing please just so I can do a quick crater run locally and make sure everything is working as expected, none of this fontc stuff is really tested in CI...
| @@ -69,13 +69,10 @@ def modify_config(self, config: dict): | |||
| extra_args = config.get("extraFontmakeArgs") or "" | |||
| extra_args += " --no-production-names --drop-implied-oncurves" | |||
| config["extraFontmakeArgs"] = extra_args | |||
| # override config to turn not build instances if we're variable | |||
| if self.will_build_variable_font(config): | |||
| config["buildStatic"] = False | |||
There was a problem hiding this comment.
Are you accomplishing this another way, or are you building statics? The current fontc mode is very much limited in focus to supporting the crater project, which lets us run both compilers and compare outputs, and I would like to avoid doing extra work in that case because it already takes quite a long time to run.
Maybe we could keep this, but have it be gated on the --fontc-experimental-single-source argument?
Normally, gftools-builder uses a small optimisation - saving intermediate UFOs in ufoLib2's "JSON structure" which is faster to serialize and parse. However, we want to turn off this optimisation when running with
fontcas it does not support this (undocumented, non-standard) UFO representation.