Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UFO->Glyphs should strip #<digit> suffix from 'Color' layer names #573

Closed
anthrotype opened this issue Jan 7, 2020 · 1 comment · May be fixed by #667
Closed

UFO->Glyphs should strip #<digit> suffix from 'Color' layer names #573

anthrotype opened this issue Jan 7, 2020 · 1 comment · May be fixed by #667

Comments

@anthrotype
Copy link
Member

in #570, we fixed the error when exporting glyphs->UFO and glyphs contain duplicate layers with the same name by appending a #<digit> suffix to make the layer name unique (UFO layers must have unique names).

However, @schriftgestalt noted that in Glyphs.app there are some special glyph layers that are used for color fonts ("Color XX" where X are numbers indicating the index of a color palette) and which can occur multiple times with the same layer name string within the same glyph master:
#566 (comment)

When going back from UFO -> glyphs, we should check if the layer name starts with "Color XX" and strip any such suffixes.
@moyogo moyogo mentioned this issue Mar 1, 2021
Open
@moyogo moyogo mentioned this issue Mar 28, 2021
Closed
@khaledhosny
Copy link
Collaborator

This is already taken care of when handling color layers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename backgrounds of layers with the same name moyogo/glyphslib
2 participants
@khaledhosny @anthrotype