Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glyphs2ufo] add --no-propagate-anchors CLI option #979

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

anthrotype
Copy link
Member

Fixes #906

Currently glyhps2ufo does the anchor propagation by default, unless the .glyphs file contains "Propagate Anchors" custom parameter set to false. There is a --propagate-anchors option but it doesn't do much since we do it even when the custom parameter is missing.

This PR adds the mutually exclusive --no-propagate-anchors which will disable this without having to modify the .glyphs file to add the custom parameter.

@anthrotype
Copy link
Member Author

anthrotype commented Feb 7, 2024

I also considered changing the default so that glyphs2ufo script does not do the anchor propagation unless requested (via either custom param explicitly set to true or via CLI option) but that would change the current behavior and might get unnoticed producing other issues down the road, so I simply added the negative option without changing the default behavior.

@anthrotype anthrotype merged commit a8399de into main Feb 7, 2024
10 checks passed
@anthrotype anthrotype deleted the no-propagate-anchors-g2ufo-cli branch February 7, 2024 14:09
@schriftgestalt
Copy link
Collaborator

I remember some mention of a cli option to control if the ufo is intended to be used to build binary files or to work on the source (and potentially round trip back). That would make the "minimal" option obsolete, too.

That option would trigger a lot preprocessing, decomposing of anchors, corner components, built kern/mark features …

So by default when you run glyphs2ufo, it would keep the data as roundtripable as possible. And if you run fontmake -g …, it would always preprocessing everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate anchors in glyphs2ufo
2 participants