Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sdotbelow, dotbelowcomb to PriAfrican glyph set, update data.json mapping for PriAfrican glyph set #144

Conversation

moyogo
Copy link
Contributor

@moyogo moyogo commented Nov 5, 2023

Fixes #141

@moyogo moyogo requested a review from chrissimpkins November 5, 2023 05:00
@moyogo moyogo mentioned this pull request Nov 5, 2023
Copy link
Member

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Denis! Do you mind opening a separate PR to integrate non-PriAfrican glyph set data in the data.json file? OK to include the PriAfrican encoding tagging here, but I will not be the one to review the other glyph sets

Lib/glyphsets/data.json Show resolved Hide resolved
@chrissimpkins chrissimpkins changed the title Add Sdotbelow, dotbelowcomb Add Sdotbelow, dotbelowcomb, update data.json mapping for PriAfrican glyph set Nov 6, 2023
@chrissimpkins chrissimpkins changed the title Add Sdotbelow, dotbelowcomb, update data.json mapping for PriAfrican glyph set Add Sdotbelow, dotbelowcomb to PriAfrican glyph set, update data.json mapping for PriAfrican glyph set Nov 6, 2023
@chrissimpkins
Copy link
Member

Thank you very much for these changes Denis!

@chrissimpkins chrissimpkins merged commit 1d08b6c into googlefonts:chrissimpkins-latin-priafrican Nov 7, 2023
1 check passed
@moyogo moyogo deleted the chrissimpkins-latin-priafrican-patch1 branch December 1, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants