Add glyphset definition for GF Latin PriAfrican #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Denis. The FAIL in the Fontbakery test in the CI is actually related to glyphsets. I will debug this early next week. |
|
I'll merge this and work on the CI problem in the main branch afterwards. The problem lies in the calculation of glyphset support. Currently, support is assumed as soon as >80% of a glyphset is covered. With the proposed changes to GF_Latin_PriAfrican, many normal Latin fonts will now be seen as supporting PriAfrican, with the shape_languages check kicking in for that glyphset. I will have to change the way the glyphset support is calculated. |
Trenorenos
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the language codes to the GF Latin PriAfrican glyphset definition. See #137.