-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added standard_viewbox_width property to config file to support fixed and zero/proportional width #460
base: main
Are you sure you want to change the base?
Conversation
… and zero/proportional width
@rsheeter Just to get an idea, how much time is expected for the PR review process? |
I don't understand why we need an additional |
Apologies, I was out for approximately July so this one has gone much longer than it should have. For context, we don't really have an SLO but typically a few days to a week. Please email or IM us if you feel we're ignoring you , it's a bit easy to lose things in the flood of GH emails. |
When we're dealing with input sets that require both fixed advanced width and proportional width, it seems challenging to accomplish this within a single build process. For instance, when setting the width to 0, all inputs appear with proportional width, which doesn't align with the intended outcome. Ideally, we aim for the majority of inputs to maintain a fixed width of 2345, while still allowing proportional or zero width for family combination-related input. |
then I think the best way would be to write a tool that modifies the svg viewbox of the fixed-advance glyphs such that it incorporates the desired placement and advance, and then run nanoemoji --width=0 so that it will treat all input svgs as proportional. |
New tool sounds possible, but it will be adding time and an extra step for over 9000 SVGs? With minimal changes, Could we streamline things by integrating this functionality directly into nanoemoji, benefiting all users, including us? |
No description provided.