Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Stylelint issues #89

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

kennethormandy
Copy link
Contributor

Currently, there are two Stylelint errors, before any changes are made to the boilerplate:

  • A dependency issue
  • A linting error from a CSS file generated by the boilerplate

The first one appears to be a relatively recent dependency issue, which outputs “TypeError: opts.node.rangeBy is not a function”. Updating PostCSS, Stylelint, and the minimum version of Node v12.x seems to resolve this. bfe18fb

The second one is a linting error from the generated fonts.css file. It looks like the indentation and variable names generated by Specimen Skeleton Support don’t pass the formatting rules, so one option would be to fix it there. But since it is a build file, I figured it would work better to ignore it in the Stylelint config. bfe18fb

Thanks!

@RoelN
Copy link
Collaborator

RoelN commented May 17, 2024

@kennethormandy Apologies for leaving this lingering for so long, I completely missed this. Thanks for contributing and fixing the errors!

@RoelN RoelN merged commit 09877e3 into googlefonts:master Feb 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants