Move PodHostName to Stable (#3517)

* Move PodHostName to Stable * feature shortcode update
googleforgames · Nov 21, 2023 · 9b69ce6 · 9b69ce6
1 parent 0b08fae
commit 9b69ce6
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/cloudbuild.yaml b/cloudbuild.yaml
@@ -296,10 +296,10 @@ steps:
             region=${versionsAndRegions[$version]}
             if [ $cloudProduct = generic ]
             then
-              featureWithGate="PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=false&PodHostname=false&SplitControllerAndExtensions=false&FleetAllocationOverflow=true&CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true"
+              featureWithGate="PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=false&SplitControllerAndExtensions=false&FleetAllocationOverflow=true&CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true"
               testCluster="standard-e2e-test-cluster-${version//./-}"
             else
-              featureWithGate="PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=false&PodHostname=false&SplitControllerAndExtensions=true&FleetAllocationOverflow=true&CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true"
+              featureWithGate="PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=false&SplitControllerAndExtensions=true&FleetAllocationOverflow=true&CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true"
               testCluster="gke-autopilot-e2e-test-cluster-${version//./-}"
             fi
             featureWithoutGate=""

diff --git a/install/helm/agones/defaultfeaturegates.yaml b/install/helm/agones/defaultfeaturegates.yaml
@@ -15,7 +15,6 @@
 # Default values for feature gates. Keep in sync with pkg/util/runtime/features.go:featureDefaults
 
 # Beta features
-PodHostname: true
 ResetMetricsOnDelete: true
 SplitControllerAndExtensions: true
 

diff --git a/pkg/util/runtime/features.go b/pkg/util/runtime/features.go
@@ -48,9 +48,6 @@ const (
 	// relevant metric views to reset their state immediately when an Agones resource is deleted.
 	FeatureResetMetricsOnDelete Feature = "ResetMetricsOnDelete"
 
-	// FeaturePodHostname enables the Pod Hostname being assigned the name of the GameServer
-	FeaturePodHostname = "PodHostname"
-
 	// FeatureFleetAllocateOverflow enables setting labels and/or annotations on Allocated GameServers
 	// if the desired number of the underlying GameServerSet drops below the number of Allocated GameServers.
 	FeatureFleetAllocateOverflow = "FleetAllocationOverflow"
@@ -101,7 +98,6 @@ var (
 	// In each of these, keep the feature sorted by descending maturity then alphabetical
 	featureDefaults = map[Feature]bool{
 		// Beta features
-		FeaturePodHostname:                  true,
 		FeatureResetMetricsOnDelete:         true,
 		FeatureSplitControllerAndExtensions: true,
 

diff --git a/site/content/en/docs/Guides/feature-stages.md b/site/content/en/docs/Guides/feature-stages.md
@@ -40,7 +40,6 @@ The current set of `alpha` and `beta` feature gates:
 {{% feature publishVersion="1.37.0" %}}
 | Feature Name                                                                                                          | Gate                           | Default  | Stage   | Since  |
 |-----------------------------------------------------------------------------------------------------------------------|--------------------------------|----------|---------|--------|
-| [GameServer Stable Network ID]({{% ref "/docs/Reference/gameserver.md#stable-network-id" %}})                         | `PodHostname`                  | Enabled  | `Beta`  | 1.32.0 |
 | [Reset Metric Export on Fleet / Autoscaler deletion]({{% relref "./metrics.md#dropping-metric-labels" %}})            | `ResetMetricsOnDelete`         | Enabled  | `Beta`  | 1.32.0 |
 | [Split `agones-controller` ](https://github.com/googleforgames/agones/issues/2797)                                    | `SplitControllerAndExtensions` | Enabled  | `Beta`  | 1.32.0 |
 | [GameServer player capacity filtering on GameServerAllocations](https://github.com/googleforgames/agones/issues/1239) | `PlayerAllocationFilter`       | Disabled | `Alpha` | 1.14.0 |

diff --git a/site/content/en/docs/Reference/gameserver.md b/site/content/en/docs/Reference/gameserver.md
@@ -133,10 +133,17 @@ The GameServer resource does not support updates. If you need to make regular up
 
 ## Stable Network ID
 
+{{% feature expiryVersion="1.37.0" %}}
 {{< beta title="Stable Network ID" gate="PodHostname" >}}
 
 If you want to connect to a `GameServer` from within your Kubernetes cluster via a convention based
 DNS entry, each Pod attached to a `GameServer` automatically derives its hostname from the name of the `GameServer`.
+{{% /feature %}}
+
+{{% feature publishVersion="1.37.0" %}}
+If you want to connect to a `GameServer` from within your Kubernetes cluster via a convention based
+DNS entry, each Pod attached to a `GameServer` automatically derives its hostname from the name of the `GameServer`.
+{{% /feature %}}
 
 To create internal DNS entries within the cluster, a group of `Pods` attached to `GameServers` can use a 
 [Headless Service](https://kubernetes.io/docs/concepts/services-networking/service/#headless-services) to control