Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsy #3415

Closed
wants to merge 3 commits into from
Closed

Docsy #3415

wants to merge 3 commits into from

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kalaiselvi84
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kalaiselvi84
Copy link
Contributor Author

Kalaiselvi84 commented Oct 5, 2023

@markmandel
I am trying with Bootstrap because Docsy uses it for layout work.

Steps followed to Migrate to Hugo Module

cp go.mod go.mod.backup
cp go.sum go.sum.backup
rm go.mod go.sum
hugo mod init github.com/agones/agones/site
hugo mod get github.com/google/[email protected]
sed -i '/theme = \["docsy"\]/d' config.toml
cat >> config.toml <<EOL
[module]
proxy = "direct"
[[module.imports]]
path = "github.com/google/docsy"
[[module.imports]]
path = "github.com/google/docsy/dependencies"
EOL
hugo server

All the above commands were successful and there were no issues.

Installed the latest version of Bootstrap and followed the steps below:

npm init -y
npm install [email protected]
site/themes/docsy/layouts/partials/head-css.html:  <link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-T3c6CoIi6uLrA9TneNEoa7RxnatzjcDSCmG1MXxSR1GAsXEV/Dwwykc2MPK8M2HN" crossorigin="anonymous">

site/themes/docsy/layouts/partials/head.html:  <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js" integrity="sha384-C6RzsynM9kWDrMNeT87bh95OGNyZPhcTNXj1NW7RuBCsyN/o0jlpcV8Qyq46cDfL" crossorigin="anonymous"></script>

hugo, site-server, site-static, hugo server, and hugo-test targets are passing. Haven't had success with the alignment of the website. Am I adding the links for CSS and JS to the correct file?

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9abef58c-1b68-41c1-9d98-e565d0c16f95

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator

I'm fairly sure that Docsy already has bootstrap embedded. Have you found that to not be the case?

@Kalaiselvi84
Copy link
Contributor Author

I'm fairly sure that Docsy already has bootstrap embedded. Have you found that to not be the case?

Since we are facing issues with the layouts and styles, I tried adding it separately, but with no luck. I'm not sure what else to try. Will close this PR.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1fb1bc5a-8fa5-4866-8b34-9a9a9328fd7a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator

Since we are facing issues with the layouts and styles, I tried adding it separately, but with no luck. I'm not sure what else to try. Will close this PR.

Don't close the PR, I'll take a look.

@Kalaiselvi84
Copy link
Contributor Author

Closing this PR, since the task has been completed in another PR: #3417

@Kalaiselvi84 Kalaiselvi84 deleted the new-docsy branch March 15, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants