Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #4070

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix broken link #4070

merged 2 commits into from
Dec 16, 2024

Conversation

0xaravindh
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@0xaravindh 0xaravindh added the kind/cleanup Refactoring code, fixing up documentation, etc label Dec 16, 2024
@0xaravindh 0xaravindh self-assigned this Dec 16, 2024
@0xaravindh 0xaravindh requested review from gongmax and igooch December 16, 2024 11:07
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 30b10807-7f75-446f-ab55-54407532ba70

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@@ -56,7 +56,7 @@ <h2 class="text-center pb-3">Companies using Agones</h2>
<a href="http://altavr.io/"><img alt="altavr" width="100" src="images/altavr-logo.png" /></a>
<a href="https://www.embark.games/"><img alt="Embark Studios" width="50" src="images/embark.png" /></a>
<a href="http://accelbyte.io/"><img alt="accelbyte" width="100" src="images/accelbyte.png" /></a>
<a href="https://space.game/"><img alt="Space Game" width="80" src="images/spacegame.png" /></a>
<img alt="Space Game" width="80" src="images/spacegame.png" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a brief Google search I couldn't find a new URL. We should remove this whole line, as well as the site/static/images/spacegame.png image since there's no URL.

Suggested change
<img alt="Space Game" width="80" src="images/spacegame.png" />

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NBoychev FYI, since this was your link!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also checked their twitter official. but I couldn't find any new links.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a second commit to remove everything so we can get this in ASAP as it's breaking our CI / CD test suite. They can resubmit a new PR with a new link and image later.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c9dc6205-461b-40fa-a97f-39cb95b8be07

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4070/head:pr_4070 && git checkout pr_4070
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-d6c0c5d

@gongmax gongmax merged commit 467e63a into googleforgames:main Dec 16, 2024
4 checks passed
@0xaravindh 0xaravindh deleted the fix/broken_link branch December 18, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants