Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm Schema Validation for topologySpreadConstraints and customCertSecretPath #4112

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

AliaksandrTsimokhau
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4111

Special notes for your reviewer:
We need this change to set correct type values which fixes json-schema-validation error: Invalid type error Expected: object, given: array

Copy link

google-cla bot commented Feb 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added size/S kind/hotfix Hotfixes for issues against release labels Feb 12, 2025
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch
Copy link
Collaborator

igooch commented Feb 12, 2025

/gcbrun

@igooch igooch enabled auto-merge (squash) February 12, 2025 19:11
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 64ebe828-7863-473a-89d6-6eee3e7ec387

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Helm validation expect array instead of list.

install/helm/agones/values.schema.json Outdated Show resolved Hide resolved
install/helm/agones/values.schema.json Outdated Show resolved Hide resolved
install/helm/agones/values.schema.json Outdated Show resolved Hide resolved
install/helm/agones/values.schema.json Outdated Show resolved Hide resolved
install/helm/agones/values.schema.json Outdated Show resolved Hide resolved
auto-merge was automatically disabled February 12, 2025 20:23

Head branch was pushed to by a user without write access

@igooch
Copy link
Collaborator

igooch commented Feb 12, 2025

/gcbrun

@igooch igooch enabled auto-merge (squash) February 12, 2025 20:36
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick PR!

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: ab9d9bd9-e52a-434c-b140-9a4bceee9867

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Copy link
Collaborator

igooch commented Feb 12, 2025

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e90feb13-364f-4287-9782-8edb2f0d8187

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4112/head:pr_4112 && git checkout pr_4112
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-a0ac906

@igooch igooch merged commit 700b19c into googleforgames:main Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/hotfix Hotfixes for issues against release size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Schema Validation for customCertSecretPath
3 participants