perf: Use enum_dispatch over dynamic dispatch

googleforgames · Oct 8, 2024 · 2be12e5 · 2be12e5
1 parent 5e1e5e7
commit 2be12e5
Show file tree

Hide file tree

Showing 13 changed files with 46 additions and 295 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -149,6 +149,7 @@ strum_macros = "0.26"
 cfg-if = "1.0.0"
 libflate = "2.0.0"
 form_urlencoded = "1.2.1"
+enum_dispatch = "0.3.13"
 
 [dependencies.hyper-util]
 version = "0.1"
@@ -236,4 +237,4 @@ schemars = { version = "0.8.15", features = ["bytes", "url"] }
 url = { version = "2.4.1", features = ["serde"] }
 
 [workspace.lints.clippy]
-undocumented_unsafe_blocks = "deny"
+undocumented_unsafe_blocks = "deny"
diff --git a/examples/quilkin-filter-example/.gitignore b/examples/quilkin-filter-example/.gitignore
diff --git a/examples/quilkin-filter-example/Cargo.toml b/examples/quilkin-filter-example/Cargo.toml
diff --git a/examples/quilkin-filter-example/README.md b/examples/quilkin-filter-example/README.md
diff --git a/examples/quilkin-filter-example/config.yaml b/examples/quilkin-filter-example/config.yaml
diff --git a/examples/quilkin-filter-example/src/generated.rs b/examples/quilkin-filter-example/src/generated.rs
diff --git a/examples/quilkin-filter-example/src/generated/greet.rs b/examples/quilkin-filter-example/src/generated/greet.rs
diff --git a/examples/quilkin-filter-example/src/greet.proto b/examples/quilkin-filter-example/src/greet.proto
diff --git a/examples/quilkin-filter-example/src/main.rs b/examples/quilkin-filter-example/src/main.rs
diff --git a/src/filters.rs b/src/filters.rs
@@ -70,8 +70,28 @@ pub use self::{
     write::WriteContext,
 };
 
+use crate::test::TestFilter;
+
 pub use self::chain::FilterChain;
 
+#[enum_dispatch::enum_dispatch(Filter)]
+pub enum FilterKind {
+    Capture,
+    Compress,
+    Concatenate,
+    Debug,
+    Drop,
+    Firewall,
+    LoadBalancer,
+    LocalRateLimit,
+    Pass,
+    Match,
+    Timestamp,
+    TokenRouter,
+    HashedTokenRouter,
+    TestFilter,
+}
+
 /// Statically safe version of [`Filter`], if you're writing a Rust filter, you
 /// should implement [`StaticFilter`] in addition to [`Filter`], as
 /// [`StaticFilter`] guarantees all of the required properties through the type
@@ -104,7 +124,7 @@ pub use self::chain::FilterChain;
 ///     }
 /// }
 /// ```
-pub trait StaticFilter: Filter + Sized
+pub trait StaticFilter: Filter + Sized + Into<FilterKind>
 // This where clause simply states that `Configuration`'s and
 // `BinaryConfiguration`'s `Error` types are compatible with `filters::Error`.
 where
@@ -207,6 +227,7 @@ where
 ///   `write` implementation to execute.
 ///   * Labels
 ///     * `filter` The name of the filter being executed.
+#[enum_dispatch::enum_dispatch]
 pub trait Filter: Send + Sync {
     /// [`Filter::read`] is invoked when the proxy receives data from a
     /// downstream connection on the listening port.