Feature/update management server #1022
Conversation
swermin
requested review from
markmandel,
XAMPPRocky,
koslib and
Jake-Shadle
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I am currently working on signing the cla, but its gonna take a while since I am doing it on the behalf of the company |
| @@ -44,6 +44,13 @@ pub struct Manage { | |||
| /// The configuration source for a management server. | |||
| #[clap(subcommand)] | |||
| pub provider: crate::config::Providers, | |||
| /// If specified, filters the available gameserver addresses to the one that | |||
| /// matches the specified type | |||
There was a problem hiding this comment.
Just noting that this will update the docs as well, since they are autogenerated - so no need for changes there.
swermin
force-pushed
the
feature/update-management-server
branch
2 times, most recently
from
ba7ed1c to
d0f1a33
Compare
|
Finally got the CLA is signed, could I get eyes on this again? 🙏 |
swermin
force-pushed
the
feature/update-management-server
branch
from
d0f1a33 to
3813600
Compare
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: bc564064-06a6-42a2-a9fd-e863e311f5bf The following development images have been built, and will exist for the next 30 days: To build this version: |
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This PR extends the
management serverto also support filtering address types for game servers the same way theagentis doing