Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: ConcatenateBytes ➡️ Concatenate #813

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

We had this in an old PR (#639), but that got held up by some other functionality.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

This has been bugging me for ages, so I just wanted to take care of it.

We had this in an old PR (googleforgames#639), but that got held up by some other
functionality.

This has been bugging me for ages, so I just wanted to take care of it.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/breaking Changes to functionality, API, etc. labels Oct 9, 2023
@github-actions github-actions bot added the size/m label Oct 9, 2023
@XAMPPRocky XAMPPRocky enabled auto-merge (squash) October 10, 2023 07:45
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: ce2aa1f0-6f29-4bc7-9a8c-0a01f26dd4d7

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/813/head:pr_813 && git checkout pr_813
cargo build

@XAMPPRocky XAMPPRocky merged commit 98af104 into googleforgames:main Oct 10, 2023
3 checks passed
@markmandel markmandel deleted the cleanup/concat-filter branch October 10, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking Changes to functionality, API, etc. kind/cleanup Refactoring code, fixing up documentation, etc size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants