Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Build: Put logs back in public bucket #817

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

I was using Cloud Build to run all the tests for myself, but forgot to add back in this section before committing 🤦🏻‍♂️.

This is me putting it back, so it's back in a public bucket and reachable by everyone.

Which issue(s) this PR fixes:

Fix for #815 (comment)

Special notes for your reviewer:

Sorry!

I was using Cloud Build to run all the tests for myself, but forgot to
add back in this section before committing 🤦🏻‍♂️.

This is me putting it back, so it's back in a public bucket and
reachable by everyone.
@markmandel markmandel added the area/tests Unit tests, integration tests, anything to make sure things don't break label Oct 10, 2023
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c1105112-665f-48cc-a405-8a63bed114d1

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/817/head:pr_817 && git checkout pr_817
cargo build

@XAMPPRocky XAMPPRocky merged commit 5f94d28 into googleforgames:main Oct 11, 2023
3 checks passed
@markmandel markmandel deleted the oops/cloud-build-log branch October 12, 2023 23:30
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, integration tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants