Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compile times #896

Merged
merged 31 commits into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b9fe60b
Remove unnecessary proc macros
Jake-Shadle Feb 28, 2024
aa1e823
Update maxmind
Jake-Shadle Feb 28, 2024
d0c44b2
Remove protoc dependency
Jake-Shadle Feb 29, 2024
8aafbfe
Update generated
Jake-Shadle Feb 29, 2024
f67bef5
Replace chrono with time
Jake-Shadle Feb 29, 2024
cf276b1
Rename ServiceClient::connect -> connect_to_endpoint
Jake-Shadle Feb 29, 2024
c0c6e15
Readd copied protobufs
Jake-Shadle Feb 29, 2024
7ed845b
Remove commented out code
Jake-Shadle Feb 29, 2024
8276c6b
Oops
Jake-Shadle Feb 29, 2024
4b783cd
Validate protobufs in CI
Jake-Shadle Feb 29, 2024
febb8b7
Format
Jake-Shadle Feb 29, 2024
12fef61
Oops
Jake-Shadle Feb 29, 2024
823dfac
Cancel on push
Jake-Shadle Feb 29, 2024
16c8ef4
Sigh, double timeout
Jake-Shadle Feb 29, 2024
53ee921
Fix tarball extraction
Jake-Shadle Feb 29, 2024
f483cb5
Double again
Jake-Shadle Feb 29, 2024
0d847dd
Sigh
Jake-Shadle Feb 29, 2024
6f04a0e
Sigh x2
Jake-Shadle Feb 29, 2024
6463837
Install protoc because ubuntu is the worst
Jake-Shadle Feb 29, 2024
e0d7eb9
Sigh
Jake-Shadle Feb 29, 2024
127ab26
Unzip shenanigans
Jake-Shadle Feb 29, 2024
ae1d61a
uhm what
Jake-Shadle Feb 29, 2024
f9d97e8
...
Jake-Shadle Feb 29, 2024
a98c48d
just bump everything
Jake-Shadle Mar 1, 2024
712d9af
Remove comments
Jake-Shadle Mar 1, 2024
971c155
Update proto-gen version
Jake-Shadle Mar 1, 2024
0db04c5
Remove v prefix
Jake-Shadle Mar 1, 2024
ae4abfb
Ugh
Jake-Shadle Mar 1, 2024
def1f7e
...
Jake-Shadle Mar 1, 2024
68b2ca9
Ignore flaky test for now
Jake-Shadle Mar 1, 2024
f88d260
Fix agones
Jake-Shadle Mar 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# GitHub action that runs https://github.com/adRise/update-pr-branch on each push to
# `main`. `update-pr-branch` will pick the oldest PR (by creation date) that is approved
# with auto-merge enabled and update it to the latest `main`, forming a best-effort queue
# of approved PRs.

name: Validate protobufs

on:
push:
branches:
- "main"
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
validate:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
submodules: true
- run: cargo run -p proto-gen -- validate
9 changes: 0 additions & 9 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,12 +1,3 @@
[submodule "proto/data-plane-api"]
path = proto/data-plane-api
url = https://github.com/envoyproxy/data-plane-api.git
[submodule "proto/udpa"]
path = proto/udpa
url = https://github.com/cncf/xds.git
[submodule "proto/protoc-gen-validate"]
path = proto/protoc-gen-validate
url = https://github.com/envoyproxy/protoc-gen-validate.git
[submodule "proto/googleapis"]
path = proto/googleapis
url = https://github.com/googleapis/googleapis.git
Loading