Fix health_server test #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running all tests in parallel with cargo nextest this would fail since the port is bound in multiple tests
Jake-Shadle
requested review from
markmandel,
XAMPPRocky and
koslib
as code owners
XAMPPRocky
reviewed
Mar 1, 2024
Co-authored-by: XAMPPRocky <[email protected]>
XAMPPRocky
approved these changes
Mar 1, 2024
|
Yah, so the reason the test was taking so long was because the metrics test also failed to bind to the port but that one didn't have a timeout and so the CI was just stuck permanently, I've gone through and (I think) made all of them ephemeral. |
|
Build Failed 😭 Build Id: 66991752-93f2-4cf8-8d47-3a11cc465183 Status: TIMEOUT To get permission to view the Cloud Build view, join the quilkin-discuss Google Group. Filter with the Git Commit Development images are retained for at least 30 days. |
markmandel
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running all tests in parallel with cargo nextest this would fail since the port is bound in multiple tests