Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate user when they are viewing a specific trip #60

Closed
keiffer01 opened this issue Jul 13, 2020 · 0 comments · Fixed by #76
Closed

Authenticate user when they are viewing a specific trip #60

keiffer01 opened this issue Jul 13, 2020 · 0 comments · Fixed by #76
Assignees
Labels
bug Something isn't working

Comments

@keiffer01
Copy link
Collaborator

Issue summary

Although users are checked to see if they are authenticated when they attempt to view a PrivateRoute page, it does not check to see if they have been listed as a collaborator when they view a specific trip's activities.

Expected behavior

User is checked to see if they are listed as a collaborator for a trip's activities. If they are, they can stay on the page. If not, they should be redirected to a page stating that they do not have the permission to view that trip, with the ability to return to their VIEW_TRIPS page.

Actual behavior

Any user can see any trip given the URL, regardless of whether or not they have been listed as a collaborator for it.

@keiffer01 keiffer01 added the bug Something isn't working label Jul 13, 2020
@keiffer01 keiffer01 self-assigned this Jul 13, 2020
@keiffer01 keiffer01 linked a pull request Jul 17, 2020 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant