-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authenticate user for trip #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zghera
requested changes
Jul 20, 2020
zghera
approved these changes
Jul 21, 2020
anan-ya-y
approved these changes
Jul 22, 2020
HiramSilvey
requested changes
Jul 24, 2020
1 task
beiebi0
approved these changes
Jul 27, 2020
HiramSilvey
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Adds an extra check on the VIEW_ACTIVITIES page to ensure that the logged-in user is a collaborator of the trip. If not, they receive an error message instead.
Is this fixing an issue?
Fixes #60
Are there more details that are relevant?
The
index.js
file of theViewActivities
component is added to. When the component mounts, it makes a query to Firestore to grab the collaborators for the requested trip. The possible rendered elements are:ActivityList
component is rendered as normal.Check lists (check
x
in[ ]
of list items)Any additional comments?
GIF below (it is dark because I was using a Night Mode extension):