Nice formatting on Activities page #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zghera
requested changes
Aug 6, 2020
| expect(actualCentral).toEqual(expectedCentral); | ||
| expect(actualSingapore).toEqual(expectedSingapore); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This could be totally wrong so getting @keiffer01, @Hiram-Silvey, or @beiebi0 's opinion would be a very good idea.
Based on feedback I got in the past, it seems like most of these tests (ones you wrote in this PR and similar others in test.js) are testing a single call to a function in the moment library. So because there is no additional logic (your own conditionals or a series of library functions called in succession), tests may not be needed for these cases.
zghera
approved these changes
Aug 7, 2020
|
Received @Hiram-Silvey 's verbal approval to merge since this is the last day of the internship and he was not able to review the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Show more information on the activities page to make for more intuitive planning.
Is this fixing an issue?
Provides a temporary fix for #132.
Are there more details that are relevant?
Check lists (check
xin[ ]of list items)Please explain why any are not present, if any.
See #140.
Any additional comments?
Just a smidge more intuitive
Before:
After:
