Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify website flows for authentication #80

Merged
merged 5 commits into from
Jul 28, 2020
Merged

Modify website flows for authentication #80

merged 5 commits into from
Jul 28, 2020

Conversation

keiffer01
Copy link
Collaborator

What is a quick description of the change?

Modify some of the authentication flows to be as described in #59.

Is this fixing an issue?

Fixes #59.

Are there more details that are relevant?

none

Check lists (check x in [ ] of list items)

  • [ ] Test written/updating
  • [ ] Tests passing
  • Coding style (indentation, etc)

No tests written as the Redirect external component was used and redirecting with useHistory had been tested before. (If you think tests should be added though I can try to add some)

Any additional comments?

@keiffer01 keiffer01 self-assigned this Jul 17, 2020
@keiffer01 keiffer01 linked an issue Jul 17, 2020 that may be closed by this pull request
@keiffer01 keiffer01 changed the title Authflows Modify website flows for authentication Jul 20, 2020
Base automatically changed from header to master July 20, 2020 23:24
frontend/src/components/SignIn/index.js Outdated Show resolved Hide resolved
@keiffer01 keiffer01 marked this pull request as ready for review July 22, 2020 19:58
frontend/src/components/Header/UserInfo.js Outdated Show resolved Hide resolved
frontend/src/components/Header/UserInfo.js Outdated Show resolved Hide resolved
frontend/src/components/Header/UserInfo.js Show resolved Hide resolved
@keiffer01 keiffer01 merged commit b082e0f into master Jul 28, 2020
@keiffer01 keiffer01 deleted the authflows branch July 28, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Authentication Flows
5 participants