-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add internalUsageAttributionId to examples. #923
base: main
Are you sure you want to change the base?
Conversation
As far as I can tell, this change wouldn't do anything, since the implementation doesn't add unknown parameters to the URL. See here: Lines 496 to 506 in a20e37b
and here: Lines 369 to 411 in a20e37b
(I don't know right now which of these two is used in which use-case, but both of them only handle well-known parameters). |
(disregard my comment, I just now realized that the values is being passed to the map constructor and not the api loader). |
Thank you Martin! I was caught up by something else so was not able to reply earlier. You are right, these parameters are part of mapOptions so they won't be passed as bootstrap parameters, instead, the user who initiate the map should attach this - if they copy/paste from the examples. |
Updated per reviewer's suggestions. TY! |
No description provided.