fix: update dependencies, fix typescript issues, repair tests (#819)

- dependencies updated to their latest versions (exceptions are typescript 5.5 and eslint 8) - all tests are back to passing, tests that never actually worked are now working - all TypeScript and ESLint Problems are fixed
googlemaps · Jan 15, 2025 · e554366 · e554366
1 parent c7019a3
commit e554366
Show file tree

Hide file tree

Showing 33 changed files with 4,665 additions and 6,627 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -20,9 +20,12 @@
       "extends": ["plugin:@typescript-eslint/recommended"],
       "rules": {
         "@typescript-eslint/ban-ts-comment": 0,
-        "@typescript-eslint/ban-types": 1,
         "@typescript-eslint/no-empty-function": 1,
         "@typescript-eslint/member-ordering": 1,
+        "@typescript-eslint/no-empty-object-type": 1,
+        "@typescript-eslint/no-unsafe-function-type": 1,
+        "@typescript-eslint/no-wrapper-object-types": 1,
+
         "@typescript-eslint/explicit-member-accessibility": [
           1,
           {

diff --git a/.github/workflows/bundlewatch.yml b/.github/workflows/bundlewatch.yml
@@ -27,9 +27,21 @@ jobs:
     env:
       CI_BRANCH_BASE: main
     steps:
-      - uses: actions/checkout@v3
-      - uses: jackyef/bundlewatch-gh-action@b9753bc9b3ea458ff21069eaf6206e01e046f0b5
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          node-version: 20
+          cache: npm
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Bundlewatch
+        uses: jackyef/bundlewatch-gh-action@b9753bc9b3ea458ff21069eaf6206e01e046f0b5
         with:
-          build-script: npm i
+          build-script: npm run prepack
           bundlewatch-github-token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
           bundlewatch-config: .github/bundlewatch.config.json
diff --git a/examples/algorithms.ts b/examples/algorithms.ts
@@ -24,6 +24,7 @@ import {
 import { MAP_ID, createMarker, getLoaderOptions, sync } from "./config";
 
 import { Loader } from "@googlemaps/js-api-loader";
+// @ts-ignore
 import trees from "./trees.json";
 
 const mapOptions: google.maps.MapOptions = {
@@ -37,17 +38,17 @@ new Loader(getLoaderOptions()).load().then(() => {
 
   const panels: [HTMLElement, AbstractAlgorithm, string][] = [
     [
-      document.getElementById("noop"),
+      document.getElementById("noop")!,
       new NoopAlgorithm({}),
       `new NoopAlgorithm()`,
     ],
     [
-      document.getElementById("grid"),
+      document.getElementById("grid")!,
       new GridAlgorithm({ maxDistance: 40000 }),
       `new GridAlgorithm({})`,
     ],
     [
-      document.getElementById("supercluster"),
+      document.getElementById("supercluster")!,
       new SuperClusterAlgorithm({}),
       `new SuperClusterAlgorithm({})`,
     ],

diff --git a/examples/bench-advanced.ts b/examples/bench-advanced.ts
@@ -17,6 +17,7 @@
 import { MAP_ID, getLoaderOptions } from "./config";
 import { Loader } from "@googlemaps/js-api-loader";
 import { MarkerClusterer } from "../src";
+
 import points from "./realworld.json";
 
 // Do not set the mapId to force legacy markers
@@ -28,7 +29,7 @@ const mapOptions: google.maps.MapOptions = {
 };
 
 new Loader(getLoaderOptions()).load().then(() => {
-  const element = document.getElementById("map");
+  const element = document.getElementById("map")!;
 
   const map = new google.maps.Map(element, mapOptions);
 

diff --git a/examples/bench-legacy-viewport.ts b/examples/bench-legacy-viewport.ts
@@ -27,7 +27,7 @@ const mapOptions: google.maps.MapOptions = {
 };
 
 new Loader(getLoaderOptions()).load().then(() => {
-  const element = document.getElementById("map");
+  const element = document.getElementById("map")!;
 
   const map = new google.maps.Map(element, mapOptions);
 

diff --git a/examples/bench-legacy.ts b/examples/bench-legacy.ts
@@ -27,7 +27,7 @@ const mapOptions: google.maps.MapOptions = {
 };
 
 new Loader(getLoaderOptions()).load().then(() => {
-  const element = document.getElementById("map");
+  const element = document.getElementById("map")!;
 
   const map = new google.maps.Map(element, mapOptions);
 

diff --git a/examples/config.ts b/examples/config.ts
@@ -45,8 +45,8 @@ export const sync = (...maps: google.maps.Map[]): void => {
 
   maps.forEach((m) => {
     m.addListener("bounds_changed", () => {
-      const changedCenter = m.getCenter();
-      const changedZoom = m.getZoom();
+      const changedCenter = m.getCenter()!;
+      const changedZoom = m.getZoom()!;
 
       if (changedCenter !== center || changedZoom !== zoom) {
         center = changedCenter;

diff --git a/examples/defaults.ts b/examples/defaults.ts
@@ -26,7 +26,7 @@ const mapOptions: google.maps.MapOptions = {
 };
 
 new Loader(getLoaderOptions()).load().then(() => {
-  const element = document.getElementById("map");
+  const element = document.getElementById("map")!;
 
   const map = new google.maps.Map(element, mapOptions);
 

diff --git a/examples/renderers.ts b/examples/renderers.ts
@@ -69,14 +69,14 @@ const interpolatedRenderer = {
 new Loader(getLoaderOptions()).load().then(() => {
   const maps: google.maps.Map[] = [];
 
-  const panels: [HTMLElement, Renderer, string][] = [
+  const panels: [HTMLElement, Renderer, string | null][] = [
     [
-      document.getElementById("default"),
+      document.getElementById("default")!,
       new DefaultRenderer(),
       `new DefaultRenderer()`,
     ],
     [
-      document.getElementById("simple"),
+      document.getElementById("simple")!,
       {
         render: ({ count, position }: Cluster) =>
           new google.maps.Marker({
@@ -88,8 +88,8 @@ new Loader(getLoaderOptions()).load().then(() => {
       },
       null,
     ],
-    [document.getElementById("svg"), new DefaultRenderer(), null],
-    [document.getElementById("interpolated"), interpolatedRenderer, null],
+    [document.getElementById("svg")!, new DefaultRenderer(), null],
+    [document.getElementById("interpolated")!, interpolatedRenderer, null],
   ];
 
   panels.forEach(([element, renderer, text]) => {

diff --git a/examples/updates.ts b/examples/updates.ts
@@ -26,7 +26,7 @@ const mapOptions: google.maps.MapOptions = {
 };
 
 new Loader(getLoaderOptions()).load().then(async () => {
-  const element = document.getElementById("map");
+  const element = document.getElementById("map")!;
 
   const map = new google.maps.Map(element, mapOptions);
 

diff --git a/jest.config.js → jest.config.cjs b/jest.config.js → jest.config.cjs
@@ -14,10 +14,11 @@
  * limitations under the License.
  */
 
+/** @type {import('ts-jest').JestConfigWithTsJest} */
 module.exports = {
-  transform: {
-    "^.+\\.tsx?$": "ts-jest",
-  },
+  preset: "ts-jest/presets/js-with-ts",
+  testEnvironment: "jsdom",
+  transformIgnorePatterns: [],
   collectCoverage: true,
   testPathIgnorePatterns: ["/dist/"],
 };