Skip to content

Commit

Permalink
Remove --random-seed argument from V8Profile
Browse files Browse the repository at this point in the history
In a typical deployment, multiple Fuzzilli instances will cooperate and
send crashing samples to a dedicated "master" instance. In such a
configuration, it doesn't make much sense for each instance to pick a
random --random-seed as all instances of such a "swarm" need to use the
same seed. As such, with this change we remove the argument from the
V8Profile. Instead, the user can pass a --random-seed argument via the
--additionalArguments and that way ensure that the same seed is used.
  • Loading branch information
Samuel Groß committed Nov 8, 2024
1 parent 8e3cfb6 commit 3f81d5a
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions Sources/FuzzilliCli/Profiles/V8Profile.swift
Original file line number Diff line number Diff line change
Expand Up @@ -462,12 +462,6 @@ let v8Profile = Profile(
//
// Future features that should sometimes be enabled.
//
if probability(0.5) {
// A (fixed) random seed can make crashes (and the engine in general) more deterministic.
let seed = Int32.random(in: Int32.min...Int32.max)
args.append("--random-seed=\(seed)")
}

if probability(0.25) {
args.append("--minor-ms")
}
Expand Down

0 comments on commit 3f81d5a

Please sign in to comment.