Fix incorrect sizes for Intel PT packets tma, pwrx, and vmcs #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While comparing the reference Intel PT decoder (i.e. from libipt) with winafl's I found some incorrect sizes in winafl's code, namely for tma, pwrx, vmcs: their size is defined as
8
but according to libipt's sources they should all be7
.See definition of
enum pt_packet_size
(https://github.com/intel/libipt/blob/4310a2f21a368d31cdfc55b37d65928f38101dc4/libipt/internal/include/pt_opcodes.h#L382)
ptps_tma = pt_opcs_tma + pt_pl_tma_size
which is= 2 + 5
ptps_pwrx = pt_opcs_pwrx + pt_pl_pwrx_size
which is= 2 + 5
ptps_vmcs = pt_opcs_vmcs + pt_pl_vmcs_size
which is= 2 + 5
There are two commits in this PR. The first one updates the lookup table dumping code to print something that has the formatting of the dump in winafl's source code. The second commit fixes the packet sizes.