Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify ssh dir #2981

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Conversation

JoelLau
Copy link
Contributor

@JoelLau JoelLau commented Oct 28, 2024

override default ~/.ssh/ directory for ssh paths

@JoelLau JoelLau force-pushed the feat/2933/custom-ssh-path branch from ad7ac91 to 67c27fe Compare October 28, 2024 19:44
@JoelLau
Copy link
Contributor Author

JoelLau commented Oct 28, 2024

@dominikschulz i realise this doesn't exactly implement the features described in #2933, but would this be a step in the right direction?

Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's not a flag, I think a env variable for that is actually more sensible.

A test would be nice too.

internal/backend/crypto/age/ssh.go Outdated Show resolved Hide resolved
internal/backend/crypto/age/ssh.go Outdated Show resolved Hide resolved
internal/backend/crypto/age/ssh.go Outdated Show resolved Hide resolved
@JoelLau JoelLau force-pushed the feat/2933/custom-ssh-path branch from 00a1b97 to 90ca354 Compare October 29, 2024 17:28
@JoelLau JoelLau marked this pull request as draft October 30, 2024 04:42
@JoelLau JoelLau force-pushed the feat/2933/custom-ssh-path branch from 90ca354 to 799289e Compare October 30, 2024 09:08
@JoelLau JoelLau force-pushed the feat/2933/custom-ssh-path branch from 799289e to bcc3b44 Compare October 30, 2024 09:09
@JoelLau JoelLau marked this pull request as ready for review October 30, 2024 13:12
@JoelLau JoelLau requested a review from AnomalRoil October 30, 2024 13:14
@JoelLau
Copy link
Contributor Author

JoelLau commented Oct 31, 2024

@AnomalRoil are there any other changes required for this PR?

@JoelLau
Copy link
Contributor Author

JoelLau commented Nov 4, 2024

if its not too much trouble, can i get this PR accepted for hacktoberfest by merging this pr or marking it with the hacktoberfest-accepted label?

internal/backend/crypto/age/ssh.go Outdated Show resolved Hide resolved
internal/backend/crypto/age/ssh.go Outdated Show resolved Hide resolved
@JoelLau JoelLau force-pushed the feat/2933/custom-ssh-path branch from 7bd36f9 to 142576f Compare November 6, 2024 08:55
internal/backend/crypto/age/ssh.go Outdated Show resolved Hide resolved
Signed-off-by: Joel Lau <[email protected]>
@JoelLau JoelLau force-pushed the feat/2933/custom-ssh-path branch from 142576f to 37705a5 Compare November 9, 2024 08:02
@dominikschulz dominikschulz merged commit ecb848f into gopasspw:master Nov 9, 2024
8 checks passed
@JoelLau JoelLau deleted the feat/2933/custom-ssh-path branch December 1, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants