Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:overload function anchor info by func.Doc #12

Open
wants to merge 12 commits into
base: goplus
Choose a base branch
from

Conversation

luoliwoshang
Copy link

@luoliwoshang luoliwoshang commented Mar 28, 2024

#11

  • Passing overload information in func.Doc
  • The anchor point of an overloaded function consists of an index and a function name.
  • corresponding test function
image

option 1
use function synopsis as the anchor to achieve the correct overloaded function jump。
1. But in doing so, the link to the anchor of the method will be very long
Consider hashing the signature
option 2
Modify the doc.Func and doc.Item types to add overloaded indexes

@luoliwoshang luoliwoshang changed the title feat:correct overload function anchor [WIP] feat:correct overload function anchor Mar 28, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.90%. Comparing base (717e2d1) to head (8ddd82d).
Report is 14 commits behind head on goplus.

Additional details and impacted files
@@            Coverage Diff             @@
##           goplus      #12      +/-   ##
==========================================
+ Coverage   55.85%   55.90%   +0.05%     
==========================================
  Files         161      161              
  Lines       16209    16230      +21     
==========================================
+ Hits         9053     9074      +21     
  Misses       6332     6332              
  Partials      824      824              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luoliwoshang luoliwoshang changed the title [WIP] feat:correct overload function anchor [WIP] feat:overload function anchor Apr 2, 2024
@luoliwoshang luoliwoshang changed the title [WIP] feat:overload function anchor feat:overload function anchor Apr 6, 2024
@luoliwoshang luoliwoshang changed the title feat:overload function anchor feat:overload function anchor info Apr 6, 2024
@luoliwoshang luoliwoshang force-pushed the correct-overload-anchor branch 3 times, most recently from d30ba6d to 0bf3991 Compare April 7, 2024 09:13
@luoliwoshang luoliwoshang changed the title feat:overload function anchor info feat:overload function anchor info by func.Doc Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants