refactor: grpc base structure #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
commented
Aug 21, 2024
| @@ -119,8 +138,8 @@ func (g *GordianGRPC) GetValidators(ctx context.Context, req *GetValidatorsReque | |||
| jsonValidators := make([]*Validator, len(vals)) | |||
| for i, v := range vals { | |||
| jsonValidators[i] = &Validator{ | |||
| PubKey: reg.Marshal(v.PubKey), | |||
| Power: v.Power, | |||
| EncodedPubKey: reg.Marshal(v.PubKey), | |||
There was a problem hiding this comment.
ref comment: #8 (comment)
I like the idea of separating the Type from the core bytes of the PubKey. Will scoping for another PR. Just updating to EncodedPubKey for now.
type PubKey interface {
PubKeyBytes() []byte
PubKeyType() string // or []byte?
Equal(other PubKey) bool
Verify(msg, sig []byte) bool
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors and adds context to some previous PR reviews made in #8