Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade install-vulkan-sdk to @v1.1.2 #26

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MarshallW906
Copy link
Collaborator

This will resolve #19

@MarshallW906 MarshallW906 self-assigned this Jan 9, 2024
@MarshallW906 MarshallW906 linked an issue Jan 9, 2024 that may be closed by this pull request
@MarshallW906 MarshallW906 marked this pull request as draft January 9, 2024 12:56
@MarshallW906
Copy link
Collaborator Author

Okay I believe alexkiri/install-vulkan-sdk WILL work but it has NOT been published into Github Actions Marketplace

Need something else

@shurunxuan
Copy link
Collaborator

You are using 1.1.2 but from their repo it seems it's 1.1.1.

@MarshallW906
Copy link
Collaborator Author

That's not the case. :(

The one available on marketplace is 1.1.1, which uses the legacy cache@v2.
There's a fork, alexkiri/install-vulkan-sdk, which uses modern actions/cache saying its version be 1.1.2, but not published.

@MarshallW906
Copy link
Collaborator Author

Is it Okay to use vulkan 1.3.250.1? Tried using another action but the way it constructs download link on Linux is correct only until 1.3.250.1

@MarshallW906
Copy link
Collaborator Author

Otherwise we fork one of the existing actions and create one on our own

@MarshallW906
Copy link
Collaborator Author

No never mind, this one even fails on mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning Elimination: Some workflow steps are deprecated
2 participants