Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrapper command #402

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

juls0730
Copy link

This PR allegedly fixes the issue described in #401 I say allegedly, because, well, I cant actually test it, because I need an API key, and I like to ship fast since it should be a simple fix, here it is. Let me restate that the fix is UNTESTED and tbf I dont even know if it works properly. if it doesnt and you want me to get back to work, you can issue me an api key at [email protected] or dont 🤷‍♀️

Copy link

cla-bot bot commented Jan 31, 2025

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to [email protected] and add your github handle to contributors list.

@blarfoon
Copy link
Member

Hey! Thanks for your PR.

Sorry for the late response. The test backend doesn't need API keys anymore, so you can just hook that up.

I will try to take a look at this PR this weekend!

@juls0730
Copy link
Author

Oh I see, I’ll test this once I get home then an update you/modify my commit. You should also probably update the readme 😅, thanks!

@juls0730
Copy link
Author

juls0730 commented Feb 21, 2025

Hey, @blarfoon, sorry if this is a bother, but I have been unable to test these changes myself as prism cannot be installed on my system for some reason, probably because I am on linux. I have signed the CLA here gorilla-devs/clabot-config#12, and am waiting for it to be merged. if you could take a look at this, that would be great, I will try a little more to get a development environment up and update you if I succeed.

Thanks for all of your work on this project!
Zoe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants