-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keybinds configuration file #55
base: master
Are you sure you want to change the base?
Conversation
Wow thanks for the pull request, I will definitely be taking a look! |
`keybinds` and `providers` config are now under the same `qtwebflix.conf` file
I like it a lot but two things.
|
Hey, sorry for the long time ! I did some little refractoring for better handling of the keybinds. The issue with the context menu not working anymore is no fixed. About your point 1., are you sure you want to edit the config file ? It's better we just provide default keybinds in the provided default config file, but overriting / modifying a config file (that is for.. human read) is always a tricky thing and something i personally wouldn't want to happend... |
use mpris player to be compatible with any implementations
I have delete netflix specific code to change rate of the video in the class Will open a new PR with new implementation of netflix |
Delete netflix specific setRate functions
Delete of
Providers
config file.Added a
qtwebflix.conf
conf file that will have contain theproviders
and the newkeybinds
section.Keybinds
The syntax will be as follow :
action=shortcut
Availabe actions :
fullscreen-toggle quit speed-up speed-down speed-default reload play pause play-pause next-episode
Shortcuts are formatted as in https://doc.qt.io/qt-5/qkeysequence.html (as string literal)
You can give multiple shortcuts to one action, they have to be separated by whitespace ( or \t) :
The last example
t,]
will be a sequential execution of the keyt
then]
.Providers
As before
This is my first time working on a Qt project so check the code troughly, maybe I did some bad stuff that I am not aware of.
`