Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to fix linting issues #904

Merged
merged 10 commits into from
May 19, 2024
Merged

Update docs to fix linting issues #904

merged 10 commits into from
May 19, 2024

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented May 9, 2024 •
edited by github-actions bot
Loading

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

  • Linting markdown in docs
  • Bump linting gh action (fix warning for deprecated NodeJS)
  • add mssing markdown files to linter CI

📚 Documentation preview 📚: https://goss--904.org.readthedocs.build/en/904/

@dklimpel dklimpel requested a review from aelsabbahy as a code owner May 9, 2024 16:03
@aelsabbahy
Copy link
Member

Enabled the job. Also, I set up a read the docs account here:

https://goss.readthedocs.io/en/latest/ (currently 404)

The link in your PR description gives me a 404.

I think this is really close, thank you for iterating on this, greatly appreciated!

@dklimpel dklimpel mentioned this pull request May 12, 2024
Open
@aelsabbahy aelsabbahy merged commit 71bc379 into goss-org:master May 19, 2024
3 checks passed
@dklimpel dklimpel deleted the liniting-docs branch May 19, 2024 07:37
@dklimpel dklimpel mentioned this pull request Jun 4, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelsabbahy aelsabbahy aelsabbahy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dklimpel @aelsabbahy