-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update and more general wording for "docker container" #934
Conversation
Thank you for submitting this. Couple of feedbacks on this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. CI is failing, not sure why yet.
The CI has problems with goss_int_test_alpine3_386
. I think the CI is not reliable. Since the last successful run (a6451d2) there were only changes at documentation.
I will revert one change. Feel free to revert more or mark the positions.
IMO docker and podman are wrapper for container engines. And both runs container. There are no special docker containers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes, otherwise looks good.
extras/dcgoss/README.md
Outdated
@@ -9,7 +9,7 @@ containers. It is based on `dgoss`. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets revert the changes in this file, since it's dcgoss aka docker-compose goss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
Also, user submitted wrapper scripts for Kubernetes [kgoss](https://github.com/goss-org/goss/tree/master/extras/kgoss) | ||
and Docker Compose [dcgoss](https://github.com/goss-org/goss/tree/master/extras/dcgoss). | ||
|
||
**Note:** For some Docker/Kubernetes healthcheck, health endpoint, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blog post references docker, this line should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Checklist
make test-all
(UNIX) passes. CI will also test thisDescription of change
Fixes: #931
📚 Documentation preview 📚: https://goss--934.org.readthedocs.build/en/934/