Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rishabh/frontend refactor - added background, changed main name/color scheme, and more #162

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

rmisra077
Copy link

No description provided.

chris-sul and others added 23 commits February 3, 2020 22:22
Pulling in Technica changes
Adding docker build for frontend
Correct the number of sponsors is displayed on Admin page
Adding github actions for tests and style
The newer 'hooks' syntax for React opts for components as functions,
rather than as classes. For stateless components, this makes a lot more
sense. For stateful components, there are more considerations, but
generally hooks allow for greater code re-use between components and
events.

This change convers some of the 'low hanging fruit' (i.e., mostly
stateless components) to the new hooks syntax.
* More big refactoring
* Changed api Dockerfile python version to fix issues
* Renamed a ton of instances of "class" to "className"
* Created a generic Modal and update several spots to use it
	* Still room for improvement here
* Replaced many instances of <Fragment></Fragement> with null
* Use <Card> in AdminProject
* Update how editProjectModal is created and rendered
* Rewrite Checkbox component
* Rewrite editProjectModal, createSponsorModal, and createChallengeModal with React hooks
* Replace much of WarningModal with GenericConfirmationModal
* Start cleanup of prop id names (modalId, createId, editId, etc -> id)
* Delete some unused? FA imports
* Rewrite Admin comp. with React hooks
* Fix ESLint errors
* Rewrite SubmitModal w/ React Hooks
* Cleanup some insane checkbox code
* Use Card in AdminSponsor; toggle body in better way
* editID, createID -> id
* added useWindowWidth(), replaced all this.state.innerWidth with it
* other classes to components, where easy to do
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants