add register tests

Sources/App/Controllers/View Controllers/RegisterViewController.swift

@@ -38,9 +38,12 @@ class RegisterViewController: RouteCollection {
 
             let hashedPassword = try BCrypt.hash(content.password)
             let newUser = User(name: content.name, email: content.email, password: hashedPassword)
+            try newUser.validate()
 
             let response = req.redirect(to: "/home").flash(.success, "Successfully registered")
             return newUser.save(on: req).transform(to: response)
+        }.catchMap { error in
+            return req.redirect(to: "/register").flash(.success, "Invalid email")
         }
     }
 }

Sources/App/Models/Requests/RegisterRequest.swift

@@ -13,4 +13,5 @@ struct RegisterRequest: Content {
     let name: String
     let password: String
     let confirmPassword: String
+    let csrf: String
 }

Tests/AppTests/Tests/Authed Tests/LoginTests.swift

@@ -35,11 +35,17 @@ class LoginTests: XCTestCase {
         let loginRequest = LoginRequest(email: "[email protected]", password: "wrong password", csrf: "n/a")
 
         let loginResponse = try app.sendRequest(to: "/login", method: .POST, data: loginRequest, contentType: .json)
+        XCTAssertEqual(loginResponse.http.status, .seeOther)
         XCTAssertEqual(loginResponse.http.headers.firstValue(name: .location), "/login")
     }
 
     /// Tests that a user with valid credentials can login
     func testLoginSuccessful() throws {
+        let _ = try User(name: "name", email: "[email protected]", password: try BCrypt.hash("password")).save(on: conn).wait()
+        let loginRequest = LoginRequest(email: "[email protected]", password: "password", csrf: "n/a")
 
+        let loginResponse = try app.sendRequest(to: "/login", method: .POST, data: loginRequest, contentType: .json)
+        XCTAssertEqual(loginResponse.http.status, .seeOther)
+        XCTAssertEqual(loginResponse.http.headers.firstValue(name: .location), "/home")
     }
 }

Tests/AppTests/Tests/Authed Tests/RegisterTests.swift

@@ -1,6 +1,7 @@
 import XCTest
 import Foundation
 import FluentMySQL
+import Crypto
 @testable import Vapor
 @testable import App
 
@@ -30,21 +31,38 @@ class RegisterTests: XCTestCase {
 
     /// Tests that an email cannot be registered twice
     func testRegisterEmailAlreadyExists() throws {
+        let _ = try User(name: "name", email: "[email protected]", password: try BCrypt.hash("password")).save(on: conn).wait()
+        let registerRequest = RegisterRequest(email: "[email protected]", name: "name", password: "password", confirmPassword: "password", csrf: "")
 
+        let registerResponse = try app.sendRequest(to: "/register", method: .POST, data: registerRequest, contentType: .json)
+        XCTAssertEqual(registerResponse.http.status, .seeOther)
+        XCTAssertEqual(registerResponse.http.headers.firstValue(name: .location), "/register")
     }
 
     /// Tests that an invalid email cannot register
     func testInvalidEmailFails() throws {
+        let registerRequest = RegisterRequest(email: "not an email", name: "name", password: "password", confirmPassword: "password", csrf: "")
 
+        let registerResponse = try app.sendRequest(to: "/register", method: .POST, data: registerRequest, contentType: .json)
+        XCTAssertEqual(registerResponse.http.status, .seeOther)
+        XCTAssertEqual(registerResponse.http.headers.firstValue(name: .location), "/register")
     }
 
     /// Tests that passwords must match
     func testRegisterPasswordsDontMatch() throws {
+        let registerRequest = RegisterRequest(email: "[email protected]", name: "name", password: "password1", confirmPassword: "password2", csrf: "")
 
+        let registerResponse = try app.sendRequest(to: "/register", method: .POST, data: registerRequest, contentType: .json)
+        XCTAssertEqual(registerResponse.http.status, .seeOther)
+        XCTAssertEqual(registerResponse.http.headers.firstValue(name: .location), "/register")
     }
 
     /// Tests that users can register successfully when meeting validation requirements
     func testSuccessfulRegister() throws {
+        let registerRequest = RegisterRequest(email: "[email protected]", name: "name", password: "password", confirmPassword: "password", csrf: "")
 
+        let registerResponse = try app.sendRequest(to: "/register", method: .POST, data: registerRequest, contentType: .json)
+        XCTAssertEqual(registerResponse.http.status, .seeOther)
+        XCTAssertEqual(registerResponse.http.headers.firstValue(name: .location), "/home")
     }
 }