Bonus Challenge Week 3

govindbalaji-s · Oct 16, 2022 · 069f5a5 · 069f5a5
1 parent ae60212
commit 069f5a5
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/src/main/java/com/redislabs/university/RU102J/dao/SiteGeoDaoRedisImpl.java b/src/main/java/com/redislabs/university/RU102J/dao/SiteGeoDaoRedisImpl.java
@@ -32,14 +32,13 @@ public Site findById(long id) {
     public Set<Site> findAll() {
         try (Jedis jedis = jedisPool.getResource()) {
             Set<String> keys = jedis.zrange(RedisSchema.getSiteGeoKey(), 0, -1);
-            Set<Site> sites = new HashSet<>(keys.size());
-            for (String key : keys) {
-                Map<String, String> site = jedis.hgetAll(key);
-                if (!site.isEmpty()) {
-                    sites.add(new Site(site));
-                }
-            }
-            return sites;
+            Pipeline pipeline = jedis.pipelined();
+            Set<Response<Map<String, String>>> responses = keys.stream()
+                    .map(pipeline::hgetAll).collect(Collectors.toSet());
+            pipeline.sync();
+            return responses.stream().map(Response::get)
+                    .filter(map -> !map.isEmpty())
+                    .map(Site::new).collect(Collectors.toSet());
         }
     }