Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BS cleanup before configure.ac script merge #961

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

BS cleanup before configure.ac script merge #961

wants to merge 11 commits into from

Commits on Feb 4, 2024

  1. Replace obsolete AC_TRY_LINK with AC_LINK_IFELSE

    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    1079bc1 View commit details
    Browse the repository at this point in the history

  2. Replace obsolete AC_TRY_LINK_FUNC with AC_LINK_IFELSE(...)

    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    a394a88 View commit details
    Browse the repository at this point in the history

  3. Replace obsolete AC_TRY_COMPILE with AC_COMPILE_IFELSE

    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    6aff0a5 View commit details
    Browse the repository at this point in the history

  4. Use same AC_LANG invocation in both configure.ac files

    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    3d7882f View commit details
    Browse the repository at this point in the history

  5. Use AS_VAR_IF and AS_IF as often as possible

    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    9398825 View commit details
    Browse the repository at this point in the history

  6. GP_CONFIG_MSG args with spaces or on multiple lines 

    Improves readability
    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    5eff4c2 View commit details
    Browse the repository at this point in the history

  7. GP_CHECK_LIBRARY arguments with spacing 

    Consistent spacing between Autoconf macro arguments (a space after
the comma) improves readability.
    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    17f224f View commit details
    Browse the repository at this point in the history

  8. AC_CHECK_HEADERS: use indented multi line argument 

    Put one header file per line in the the argument to
AC_CHECK_HEADERS().

This improves readability, makes diffs easier to read,
allows for easier sorting, etc.
    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    07f7e39 View commit details
    Browse the repository at this point in the history

  9. AC_CHECK_FUNCS: use indented multi line argument 

    Put one function name per line in the the argument to
AC_CHECK_FUNCS().

This improves readability, makes diffs easier to read,
allows for easier sorting, etc.
    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    f3cd644 View commit details
    Browse the repository at this point in the history

  10. AC_CHECK_(FUNCS|HEADERS): sort arguments removing duplicates

    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    3f098a6 View commit details
    Browse the repository at this point in the history

  11. Define location of libgphoto2(_port)?.la as variable 

    Using one variable throughout the whole buildsystem to
point to the built libgphoto2.la and libgphoto2_port.la
library files makes the Makefile.am lines shorter right
now, and also makes it easier to move the library file
locations later.
    @ndim
    ndim committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    7cef7e5 View commit details
    Browse the repository at this point in the history