include missing <cstdint> #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc 13 moved some includes around and as a result <cstdint> is no longer transitively
included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Signed-off-by: Khem Raj <[email protected]>
|
Any chance this could be merged? It's currently a blocker for me 😢 |
alexdewar
added a commit
to alexdewar/vcpkg
that referenced
this pull request
Jun 6, 2023
Crossguid no longer compiles with gcc v13 (tested on Linux), due to a missing include (cstdint). There is an upstream pull request to fix the issue which has been open for some time but not yet merged [1]. Let's patch the sources in vcpkg until upstream fixes it. Fixes microsoft#31834. [1] graeme-hill/crossguid#67
dan-shaw
pushed a commit
to microsoft/vcpkg
that referenced
this pull request
Jun 7, 2023
* [crossguid] Fix compilation on gcc v13 Crossguid no longer compiles with gcc v13 (tested on Linux), due to a missing include (cstdint). There is an upstream pull request to fix the issue which has been open for some time but not yet merged [1]. Let's patch the sources in vcpkg until upstream fixes it. Fixes #31834. [1] graeme-hill/crossguid#67 * [crossguid] Bump port-version
|
Blocker for us as well. Our static analysis now fails to even build. |
|
Just a note, this repo seems to have last seen any changes 5 years ago and the author seems to have last had any activity at all on GitHub 2 years ago. It may be at a point where the repo should be forked and a new maintainer take over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 13 moved some includes around and as a result is no longer transitively included [1]. Explicitly include it for uint{32,64}_t.
[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
Signed-off-by: Khem Raj [email protected]