-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DisplayVersion to Windows UninstallKey #1847
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ping windows expert @mattdurham @jkroepke, any concerns about this?
windows exporter is using MSI installer which brings that out of the box. No idea here. |
One day we will switch to MSI, likely makes things better. This feels reasonable. |
This PR has not had any activity in the past 30 days, so the |
PR Description
Adds the DisplayVersion value to the uninstallation-string of the Windows NSIS installer.
The DisplayVersion can be used as a comparison operator for patch management in enterprise environments.
PR Checklist