Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DisplayVersion to Windows UninstallKey #1847

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

charlygott
Copy link

PR Description

Adds the DisplayVersion value to the uninstallation-string of the Windows NSIS installer.
The DisplayVersion can be used as a comparison operator for patch management in enterprise environments.

PR Checklist

  • CHANGELOG.md updated

@charlygott charlygott requested a review from a team as a code owner October 8, 2024 13:35
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ping windows expert @mattdurham @jkroepke, any concerns about this?

@jkroepke
Copy link
Contributor

lgtm, ping windows expert @mattdurham @jkroepke, any concerns about this?

windows exporter is using MSI installer which brings that out of the box. No idea here.

@mattdurham
Copy link
Collaborator

One day we will switch to MSI, likely makes things better. This feels reasonable.

Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants