Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelcol.processor.cumulativetodelta: new component #2689

Merged
merged 7 commits into from
Feb 14, 2025

Conversation

madaraszg-tulip
Copy link
Contributor

@madaraszg-tulip madaraszg-tulip commented Feb 11, 2025

PR Description

Introduce a new otelcol component which tracks metric streams with the cumulative temporality and converts them into the delta temporality.

This component is initially introduced at the public preview level, as the upstream component is currently beta.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@madaraszg-tulip madaraszg-tulip changed the title Initial implementation of cumulativetodelta otelcol.processor.cumulativetodelta: new component Feb 11, 2025
@madaraszg-tulip madaraszg-tulip marked this pull request as ready for review February 11, 2025 14:23
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Most are simply layout/markdown style changes. These changes align this new topic with the incoming changes for the rest of the component topics.

Some rework on the descriptions of auto, drop, and keep. Please double check that the technical meaning and accuracy is still there.

Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks a lot!

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 13, 2025
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@madaraszg-tulip madaraszg-tulip force-pushed the madaraszg.cumulativetodelta branch from b0fe4e7 to 93f2585 Compare February 14, 2025 10:22
@wildum wildum merged commit 4573fa5 into grafana:main Feb 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants