Fix bugs

grafana · Feb 21, 2025 · 9320570 · 9320570
1 parent 405fb7c
commit 9320570
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkg/export/otel/metrics.go b/pkg/export/otel/metrics.go
@@ -253,7 +253,10 @@ func ReportMetrics(
 		if mr.cfg.SpanMetricsEnabled() || mr.cfg.ServiceGraphMetricsEnabled() {
 			hostMetrics := mr.newMetricsInstance(nil)
 			hostMeter := hostMetrics.provider.Meter(reporterName)
-			mr.setupHostInfoMeter(hostMeter)
+			err := mr.setupHostInfoMeter(hostMeter)
+			if err != nil {
+				return nil, fmt.Errorf("setting up host metrics: %w", err)
+			}
 		}
 
 		return mr.reportMetrics, nil

diff --git a/pkg/export/prom/prom.go b/pkg/export/prom/prom.go
@@ -650,7 +650,9 @@ func (r *metricsReporter) observe(span *request.Span) {
 	}
 	t := span.Timings()
 	r.beylaInfo.WithLabelValues(span.Service.SDKLanguage.String()).metric.Set(1.0)
-	r.tracesHostInfo.WithLabelValues(r.hostID).metric.Set(1.0)
+	if r.cfg.SpanMetricsEnabled() || r.cfg.ServiceGraphMetricsEnabled() {
+		r.tracesHostInfo.WithLabelValues(r.hostID).metric.Set(1.0)
+	}
 	duration := t.End.Sub(t.RequestStart).Seconds()
 
 	targetInfoLabelValues := r.labelValuesTargetInfo(span.Service)