Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process metrics dashboard #1672

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Feb 18, 2025

Solves #1670

image

@mariomac mariomac added the bug label Feb 18, 2025
@mariomac mariomac requested a review from a team as a code owner February 18, 2025 09:27
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.70%. Comparing base (3c4e678) to head (449b507).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1672      +/-   ##
==========================================
+ Coverage   69.67%   69.70%   +0.02%     
==========================================
  Files         209      209              
  Lines       20965    20965              
==========================================
+ Hits        14608    14614       +6     
+ Misses       5653     5648       -5     
+ Partials      704      703       -1     
Flag Coverage Δ
integration-test 53.95% <ø> (+0.05%) ⬆️
k8s-integration-test 55.34% <ø> (+0.31%) ⬆️
oats-test 35.25% <ø> (ø)
unittests 46.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marevers marevers self-requested a review February 18, 2025 11:55
Copy link
Collaborator

@marevers marevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense, for rate, $__rate_interval should always be used.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 126020c into grafana:main Feb 20, 2025
14 checks passed
@mariomac mariomac deleted the fix-process-dashboard branch February 20, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants