Traces host info metric #1689
Merged
Traces host info metric #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
reviewed
Feb 21, 2025
pkg/export/otel/metrics.go
Outdated
| @@ -536,6 +544,21 @@ func (mr *MetricsReporter) setupSpanMeters(m *Metrics, meter instrument.Meter) e | |||
| return nil | |||
| } | |||
|
|
|||
| func (mr *MetricsReporter) setupHostInfoMeter(meter instrument.Meter) error { | |||
| if !mr.cfg.SpanMetricsEnabled() || !mr.cfg.ServiceGraphMetricsEnabled() { | |||
There was a problem hiding this comment.
This check is duplicate before invoking setupHostInfoMeter, but also is inconsistent. Shouldn't be:
if !mr.cfg.SpanMetricsEnabled() && !mr.cfg.ServiceGraphMetricsEnabled() {
?
There was a problem hiding this comment.
Yeah, you are right, I'll remove it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1689 +/- ##
==========================================
+ Coverage 69.69% 69.86% +0.16%
==========================================
Files 209 209
Lines 20975 21047 +72
==========================================
+ Hits 14619 14704 +85
+ Misses 5654 5637 -17
- Partials 702 706 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the traces host info metric export in Beyla for OTEL and Prometheus export to support host based pricing, for vendors that charge with that model.