Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshaling bug #1690

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

grcevski
Copy link
Contributor

I recently changed the data for the HTTP2 connections, but I accidentally broke the restoring of HTTP2 connections which are not detected initially.

@grcevski grcevski requested a review from a team as a code owner February 21, 2025 15:30
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (c6e7e12) to head (8307d55).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
- Coverage   69.76%   69.69%   -0.07%     
==========================================
  Files         209      209              
  Lines       21006    21006              
==========================================
- Hits        14655    14641      -14     
- Misses       5649     5659      +10     
- Partials      702      706       +4     
Flag Coverage Δ
integration-test 54.15% <100.00%> (+0.09%) ⬆️
k8s-integration-test 54.23% <0.00%> (-0.24%) ⬇️
oats-test 35.19% <100.00%> (+0.03%) ⬆️
unittests 46.23% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit b3b488d into grafana:main Feb 21, 2025
13 checks passed
@grcevski grcevski deleted the fix_http2_connection_restore branch February 21, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants