Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.0] Fix OTEL HTTP exclusion detection #1691

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Backport dabf256 from #1688


If the OTEL endpoint has a path prefix (e.g. /otlp as in Grafana Cloud), the OTEL Exclusion detection mechanism won't work.

* Fix OTEL HTTP exclusion detection

* Fix grpc and add traces too

* add unit test

(cherry picked from commit dabf256)
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (1e6be4e) to head (4c3eca3).
Report is 1 commits behind head on release-2.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.0    #1691      +/-   ##
===============================================
- Coverage        68.80%   68.72%   -0.08%     
===============================================
  Files              208      208              
  Lines            20658    20658              
===============================================
- Hits             14213    14198      -15     
- Misses            5752     5763      +11     
- Partials           693      697       +4     
Flag Coverage Δ
integration-test 52.70% <100.00%> (-0.28%) ⬇️
k8s-integration-test 52.89% <100.00%> (-0.01%) ⬇️
oats-test 34.71% <0.00%> (-0.02%) ⬇️
unittests 45.81% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafaelroquetto rafaelroquetto merged commit d87ca32 into release-2.0 Feb 21, 2025
14 checks passed
@rafaelroquetto rafaelroquetto deleted the backport-1688-to-release-2.0 branch February 21, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants