-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting inter-zone traffic #1696
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
==========================================
+ Coverage 69.67% 69.81% +0.14%
==========================================
Files 209 209
Lines 21006 21065 +59
==========================================
+ Hits 14635 14707 +72
+ Misses 5664 5644 -20
- Partials 707 714 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minor wording change requested.
docs/sources/network/inter-az.md
Outdated
|
||
## Use the `beyla.network.inter.zone` metric | ||
|
||
Using a separate metric for inter-zone traffic allows measuring it with a reduced impact in the metrics cardinality, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd reword this paragraph as this, Sean might have a better version :) :
Using a separate metric for inter-zone traffic reduces the metric cardinality impact of collecting this data,
because the src.zone
and dst.zone
attributes are not added to the regular network metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion 👍
Fantastic. This is a really great addition! LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes suggested.
docs/sources/network/inter-az.md
Outdated
# Measure traffic between Cloud availability zones | ||
|
||
{{< admonition type="note" >}} | ||
Currently, this feature is only available in Kubernetes clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, this feature is only available in Kubernetes clusters. | |
This feature is currently only available in Kubernetes clusters. |
docs/sources/network/inter-az.md
Outdated
|
||
## Use the `beyla.network.inter.zone` metric | ||
|
||
Using a separate metric for inter-zone traffic allows measuring it with a reduced impact in the metrics cardinality, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion 👍
Addresses #1610