-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to auto-instrument with the OTel Java SDK #1704
Changes from 10 commits
9667d6c
895e54e
af7dd9e
e252dc6
696eb90
9abd50e
cefd5cf
27c68ca
0bba876
e61da9e
b06feb9
f798e2d
1a4dfbb
74474ec
5b6c7b8
b6039a0
8f4acab
039c17d
396da18
9283c78
0a86c8b
c3c67ab
740f620
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,4 +59,7 @@ type EBPFTracer struct { | |
|
||
// Enables debug printing of the protocol data | ||
ProtocolDebug bool `yaml:"protocol_debug_print" env:"BEYLA_PROTOCOL_DEBUG_PRINT"` | ||
|
||
// Enables Java instrumentation with the OpenTelemetry JDK Agent | ||
UseOTelSDKForJava bool `yaml:"use_otel_sdk_for_java" env:"BEYLA_USE_OTEL_SDK_FOR_JAVA"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reading the code above, I assume that enabling this would only generate OTEL metrics or traces. I think we should validate that if Prometheus is enabled this option can't be enabled. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this happens right now: With prometheus scrape Metrics will be false, so we'll program it to send traces only. |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As something to improve in the future, we should find a way track the javaagent version and include it in our vulnerability scans.