-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example deployment #1705
Fix example deployment #1705
Conversation
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
+ Coverage 67.34% 69.81% +2.47%
==========================================
Files 209 209
Lines 21065 21065
==========================================
+ Hits 14186 14707 +521
+ Misses 6144 5644 -500
+ Partials 735 714 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
(cherry picked from commit 837114e)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-1705-to-release-2.0 origin/release-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 837114ec4a693af2f02e6278420a29f1de59bfdb When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-1705-to-release-2.0
# Create the PR body template
PR_BODY=$(gh pr view 1705 --json body --template 'Backport 837114ec4a693af2f02e6278420a29f1de59bfdb from #1705{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release-2.0] Fix example deployment' --body-file - --label 'type/docs' --label 'backport' --base release-2.0 --milestone release-2.0 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-1705-to-release-2.0
# Create a pull request where the `base` branch is `release-2.0` and the `compare`/`head` branch is `backport-1705-to-release-2.0`.
# Remove the local backport branch
git switch main
git branch -D backport-1705-to-release-2.0 |
(cherry picked from commit 837114e) Co-authored-by: Mario Macias <[email protected]>
The goblog image was updated with some fixes, but it added a breaking change that caused the K8s deployment example to crash.