Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.21 #544

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Bump go version to 1.21 #544

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4219367
Bump go version to 1.21.8
jesusvazquez Mar 12, 2024
3530237
Set it to 1.21
jesusvazquez Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,15 @@ jobs:
test:
working_directory: /home/circleci/go/src/github.com/grafana/carbon-relay-ng
docker:
- image: cimg/go:1.20.5
- image: cimg/go:1.21.8
steps:
- checkout
- run: make test

build:
working_directory: /home/circleci/go/src/github.com/grafana/carbon-relay-ng
docker:
- image: cimg/go:1.20.5
- image: cimg/go:1.21.8
steps:
- checkout
- run: go install github.com/go-bindata/go-bindata/...@latest
Expand Down Expand Up @@ -166,7 +166,7 @@ jobs:

github_binaries:
docker:
- image: cimg/go:1.20.5
- image: cimg/go:1.21.8
steps:
- checkout
- run: curl -sfL https://goreleaser.com/static/run | bash
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/grafana/carbon-relay-ng

go 1.20
go 1.21.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just say go 1.21 and that will pick up whatever the latest go 1.21 is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know that was the actual behavior, lets do that.


require (
cloud.google.com/go v0.18.1-0.20180119164648-b1067c1d21b5
Expand Down